[TaskExecutors] Task initializer and withTaskExecutor parameter changes #70783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Related proposal text swiftlang/swift-evolution#2271 |
ktoso
added
the
concurrency runtime
ktoso
force-pushed
the
wip-cleanup-task-executor-parameters
branch
from
447b90e to
8db39ed
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-cleanup-task-executor-parameters
branch
from
8db39ed to
025b21a
Compare
ktoso
force-pushed
the
wip-cleanup-task-executor-parameters
branch
from
025b21a to
7152811
Compare
ktoso
commented
Jan 15, 2024
| } | ||
| // TODO: introduce a set {} once we are ready to allow customizing the | ||
| // default global executor. This should be done the same for main actor | ||
| } |
There was a problem hiding this comment.
so here's the new global @DougGregor
ktoso
commented
Jan 15, 2024
| @@ -121,7 +121,7 @@ public struct UnownedJob: Sendable { | |||
| @available(SwiftStdlib 9999, *) | |||
| @_alwaysEmitIntoClient | |||
| @inlinable | |||
| public func runSynchronously(isolated serialExecutor: UnownedSerialExecutor, | |||
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
carlos4242
pushed a commit
to carlos4242/swift
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #68793 bases on SE input.
This API revision allows passing
(any TaskExecutor)?to all the new APIs. Passingnilas a preference means "no preference" which means that the parent's executor preference is used for structured concurrency, and the means no change in unstructured tasks but is a simple way to pass around an optional preference through APIs if necessary.We also introduce a new global
nonisolated(unsafe) var globalConcurrentExecutor: any TaskExecutor { get }.Previous revision
Previous API shape required the
nilvalue to be used as "no preference".During review we came up with an idea that if we make the "default global concurrent executor" an accessible value, we can express it as:
withTaskExecutor(.default)and therefore avoid thenilwhich can be a bit cryptic.It does mean we have to add
public final class DefaultConcurrentExecutorwhich delegates to the "default global executor" but the APIs can then use it.The
Task(on: .default)reads a bit weird now though. Perhaps we should change it toTask(executorPreference: .default), and do the same to theaddTask(executorPreference: ...)and friends now that the.defaultcan be passed?