[Distributed] Fix _executeDistributedTarget ABI #71725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
force-pushed
the
wip-fix-anyobject-da
branch
from
3f08bda to
afd521f
Compare
ktoso
commented
Feb 20, 2024
| @@ -652,8 +652,8 @@ public struct RemoteCallTarget: CustomStringConvertible, Hashable { | |||
|
|
|||
| @available(SwiftStdlib 5.7, *) | |||
| @_silgen_name("swift_distributed_execute_target") | |||
| func _executeDistributedTarget<D: DistributedTargetInvocationDecoder, DA: DistributedActor>( | |||
| on actor: DA, // DistributedActor | |||
| func _executeDistributedTarget<D: DistributedTargetInvocationDecoder>( | |||
There was a problem hiding this comment.
^ we needed to undo this introduction of the DA parameter here to avoid breaking ABI
ktoso
force-pushed
the
wip-fix-anyobject-da
branch
from
afd521f to
779f893
Compare
ktoso
requested review from
xedin,
slavapestov and
hborla
and removed request for
slavapestov
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not change the signature of
_executeDistributedTargetand we actually do not need to -- we do not use the witness table of actor type at all.This is a follow up to #70842 which too aggressively added that generic parameter to runtime entry point