[build-script] Avoid stripping clang builtin .a libraries when extracting dSYMs on Darwin #71986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting dSYMs on Darwin
edymtt
approved these changes
Feb 29, 2024
| @@ -3230,20 +3230,21 @@ for host in "${ALL_HOSTS[@]}"; do | |||
| printJSONStartTimestamp dsymutil | |||
| (cd "${host_symroot}" && | |||
| find ./"${CURRENT_PREFIX}" -perm -0111 -type f -not -name "*.a" -not -name "*.py" -print | \ | |||
| xargs -n 1 -P ${DSYMUTIL_JOBS} ${dsymutil_path}) | |||
| xargs -t -n 1 -P ${DSYMUTIL_JOBS} ${dsymutil_path}) | |||
There was a problem hiding this comment.
Thanks for adding this flag -- that will make debugging issues much easier
|
@swift-ci please test |
…m/dsymutil_jobs.test
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang builtins (.a libraries inside lib/swift/clang/lib/darwin) are sometimes problematic to strip (because stripping .a/.o files involves calling the linker) and it's somewhat wrong to strip them in the first place (because they get consumed into linked products which might want to still extract dSYMs but if the .a is already stripped, then debug info for the .a content is already lost). Let's avoid stripping Clang builtins.
rdar://123844745