Fix @isolated(any) for distributed actors
#72035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmccall
requested review from
ktoso,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro and
tshortli
as code owners
|
@swift-ci Please test |
ktoso
reviewed
Mar 2, 2024
| distributed actor DA { | ||
| distributed func testDistributedIsolation() { | ||
| takeInheritingAsyncIsolatedAny { | ||
| await self.asyncAction() |
rjmccall
force-pushed
the
fix-distributed-actor-isolated-any
branch
from
69c25ad to
b73efae
Compare
|
@swift-ci Please test |
|
@swift-ci please test macOS platform |
First, and I really should've checked this, but global actors do not require `shared` to return `Self`; adjust the logic to propagate the right formal type to the erasure logic. Second, handle attempts to erase the isolation of something isolated to a distributed actor using the magic Actor conformance that Doug added. This only works when the actor is local, but it shouldn't be difficult to enforce that we only attempt to erase isolation what that's true --- we need to prevent partial application of distributed actors, and we need to disallow explicit isolated captures of distributed actors when we're not currently isolated to it. Otherwise, it's not possible to get an @isolated(any) function value with an isolation that isn't the current function's isolation, which means it always has to be local. Fixed rdar://123734019
rjmccall
force-pushed
the
fix-distributed-actor-isolated-any
branch
from
b73efae to
43b9b28
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.