-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Metadata and runtime support for suppressible protocol requirements #72470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DougGregor
merged 9 commits into
swiftlang:main
from
DougGregor:dynamic-suppressible-protocols
Mar 27, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
32a5b4f
Move "suppressible protocol" information into a separate .def file
DougGregor 223645c
Remove never-used "version" field from `ContextDescriptorFlags`.
DougGregor b167eec
Metadata and runtime support for suppressible protocol requirements
DougGregor 5b02006
Extend runtime checking for suppressible protocols
DougGregor 11774e5
[Runtime] Check function types against suppressible protocols
DougGregor af38d88
Fix typos spotted by code review, thank you!
DougGregor cd20dba
[Runtime] Don't check suppressible protocols for non-key generic argu…
DougGregor 5746c11
Drop constexpr rejected by Visual C++
DougGregor 3339edb
Remote more constexpr's that Visual C++ doesn't like
DougGregor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remember which C++ revision we require, but C++20 has
std::popcount()
for this. Alternatively LLVM hasllvm::popcount()
(but we'd probably need to add the necessary header to our copy in thestdlib
directory?) and Clang has__builtin_popcount()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd probably need to pull in the header. I'd like to handle this as a follow-up, because dragging another LLVM header into the runtime is the kind of thing that will find a way to blow up on me somewhere.