Do not install binary swiftmodule for Darwin #72590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also amend the installation code handling macCatalyst to match the one for regular swiftmodules.
|
@swift-ci please test |
|
@swift-ci please test WebAssembly |
|
@swift-ci please build toolchain |
edymtt
requested review from
etcwilde,
compnerd and
ian-twilightcoder
and removed request for
a team
|
Discussed this with Evan offline -- the long term solution would be to leverage the |
|
Does it make sense to invert the flag and add an install Swift module flag instead? |
ian-twilightcoder
approved these changes
Mar 26, 2024
edymtt
force-pushed
the
edymtt/no-darwin-binary-swiftmodule-in-toolchain
branch
from
c5ddf9f to
cd17f74
Compare
This is needed to support Apple internal configurations that would fail consuming such binary swiftmodule (but work as expected when rebuilding from the swiftinterface). Addresses rdar://124390643
edymtt
force-pushed
the
edymtt/no-darwin-binary-swiftmodule-in-toolchain
branch
from
cd17f74 to
0cac358
Compare
|
@swift-ci please test |
|
@swift-ci please test WebAssembly |
|
@swift-ci please build toolchain |
|
@swift-ci Please Test Source Compatibility Release |
|
@swift-ci please clean test macOS |
|
The source compatibility suite has the same 9 failures of the main run. |
etcwilde
approved these changes
Mar 27, 2024
compnerd
approved these changes
Mar 28, 2024
|
Verified this has no changes for the Linux toolchain, and only Darwin binary swiftmodules are dropped in the macOS one: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support Apple internal configurations that would fail
consuming such binary swiftmodule (but work as expected when rebuilding
from the swiftinterface).
Take the chance to cleanup the installation code for stdlib modules -- namely remove duplication and align the macCatalyst logic.
Addresses rdar://124390643