[6.0] Serialization: Harden recovery from broken deserialization context #72631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceKit has been known to crash in readInheritedProtocolConformance. Let's make it more resilient. rdar://110026935
rdar://125188407
|
@swift-ci Please test |
nkcsgexi
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both SourceKit and LLDB deserialize swiftmodule files and trigger more issues than normal compilation. SourceKit supports swiftmodules with errors and may see more mismatching context, while LLDB force loading more dependencies which may be missing and leading to a different context. Fix a few issues encountered by these tools by passing up any error instead of crashing.
Scope: Affects the deserialization logic shared by the compiler, LLDB and SourceKit.
Issue: rdar://110026935&125188407
Original PR: #72561
Risk: Very low, this change will give a chance to the compiler to keep going where it currently crashes.
Testing: There are no new tests, the services used here are already widely tested.
Reviewer: @adrian-prantl