Concurrency: Declare explicit Failure typealiases on AsyncSequence iterators #72645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erators. Associated type inference ought to take care of providing the `Failure` typealias for these `AsyncIteratorProtocol` types. However, the inferred typealias is printed with `@_implements` in the `.swiftinterface`, guarded with the `$AssociatedTypeImplements` language feature guard, which means older compilers cannot see the typealias and therefore think the conformance is incomplete. To make sure the `_Concurrency` module's interface is backward compatible, we must manually define these typealiases temporarily. Part of rdar://125138945
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated type inference ought to take care of providing the
Failuretypealias for theseAsyncIteratorProtocoltypes. However, the inferred typealias is printed with@_implementsin the.swiftinterface, guarded with the$AssociatedTypeImplementslanguage feature guard, which means older compilers cannot see the typealias and therefore think the conformance is incomplete. To make sure the_Concurrencymodule's interface is backward compatible, we must manually define these typealiases temporarily.Part of rdar://125138945