Runtime checking for associated types conforming to invertible protocols #72788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the non-zero-sized associated values of a type were considered when determining whether an enum is copyable or was trivially-destructible, meaning that a zero-sized, noncopyable type with a `deinit` wouldn't get destroyed. Treat these associated values as if they were a payload, and centralize the logic for figuring out these overall aspects of the enum (copyable, trivially-destructible, bitwise-takable) since the same checks were repeated. Fixes rdar://118449507.
Emit metadata for runtime checks of conformances of associated types to invertible protocols, e.g., `T.Assoc: Copyable`. This allows us to correctly handle, e.g., dynamic casting involving conditional conformances that have such constraints. The model we use here is to emit an invertible-protocol constraint that leaves only the specific bit clear in the invertible protocol set.
DougGregor
requested review from
mikeash,
al45tair,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit metadata for runtime checks of conformances of associated types to
invertible protocols, e.g.,
T.Assoc: Copyable. This allows us tocorrectly handle, e.g., dynamic casting involving conditional
conformances that have such constraints.
The model we use here is to emit an invertible-protocol constraint
that leaves only the specific bit clear in the invertible protocol
set.