[Macros] Use SwiftCompilerPluginMessageHandling JSON encoder/decoder #72999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift-syntax#2598 |
rintaro
force-pushed
the
macros-pluginjson
branch
from
e028933 to
56a6fe0
Compare
|
swiftlang/swift-syntax#2618 |
Replacing swiftLLVMSJON with SwiftCompilerPluginMessageHandling.JSON
rintaro
force-pushed
the
macros-pluginjson
branch
from
56a6fe0 to
1125828
Compare
|
swiftlang/swift-syntax#2618 |
|
@swift-ci Please smoke test |
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi and
hamishknight
as code owners
ahoppen
approved these changes
Apr 27, 2024
2 tasks
hamishknight
approved these changes
Apr 29, 2024
Comment on lines
2
to
+4
| # _swiftCSwiftPluginServer is just a C support library for swift-plugin-server | ||
| # Don't bother to create '.a' for that. | ||
| add_swift_host_library(_swiftCSwiftPluginServer OBJECT | ||
| add_swift_host_library(_swiftCSwiftPluginServer STATIC |
There was a problem hiding this comment.
Looks like the comment needs updating
There was a problem hiding this comment.
Let me clean this up in followups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftLLVMSJONwithSwiftCompilerPluginMessageHandling.JSONswiftLLVMJSONSwiftCompilerPluginMessageHandling.StandardIOMessageConnectioninswift-plugin-server