Skip to content

[Windows] Build SwiftCompilerPlugin module when testing swift #73010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 12, 2024

build.ps1 doesn't test executable plugins at all. That means it doesn't even try to compile SwiftComplerPlugin module. At least, let's build it when testing Swift so we can verify the build breakage in PR testing.

@rintaro
Copy link
Member Author

rintaro commented Apr 12, 2024

@swift-ci Please test Windows

@rintaro
Copy link
Member Author

rintaro commented Apr 12, 2024

@swift-ci Please smoke test macOS

@rintaro
Copy link
Member Author

rintaro commented Apr 12, 2024

@swift-ci Please smoke test Linux

@rintaro rintaro requested a review from compnerd April 12, 2024 21:49
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but why is this not wired up into the check-swift target if its meant for testing?

@rintaro
Copy link
Member Author

rintaro commented Apr 12, 2024

why is this not wired up into the check-swift target if its meant for testing?

As long as it imports Foundation, it cannot be a part of swift-test 😢
For non-Windows, we build swift-syntax/Examples (using swiftpm) which includes macros using SwiftCompilerPlugin as a part of swift-syntax tests

@rintaro rintaro marked this pull request as ready for review April 12, 2024 22:00
@rintaro rintaro merged commit abaa638 into swiftlang:main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants