Skip to content

[6.0🍒] NCGenerics: permit syntax always #73132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 23, 2024
Merged

[6.0🍒] NCGenerics: permit syntax always #73132

merged 6 commits into from
Apr 23, 2024

Conversation

kavon
Copy link
Member

@kavon kavon commented Apr 19, 2024 •
edited
Loading

  • Explanation: Removes guards to the syntax of NoncopyableGenerics. Clean up now-unused code.
  • Scope: Just syntactic
  • Issue: rdar://126730410
  • Original NCGenerics: permit syntax always #73131
  • Risk: None
  • Testing: Tests included
  • Reviewer:

@kavon
NCGenerics: omit flag in interfaces
9a750e9 
Also cleans-up legacy code and tests that are no longer needed.

(cherry picked from commit b3d5482)
@kavon kavon requested a review from a team as a code owner April 19, 2024 05:16
@kavon
Copy link
Member Author

kavon commented Apr 19, 2024

@swift-ci test

@kavon
Update additional tests after flag change
6306abc 
rdar://126730410
(cherry picked from commit 6050a96)
@kavon
Copy link
Member Author

kavon commented Apr 19, 2024

@swift-ci test

@kavon
Copy link
Member Author

kavon commented Apr 19, 2024

@swift-ci test

kavon added 2 commits April 19, 2024 11:48
@kavon
remove suppression disablement workaround
1589853 
(cherry picked from commit dc88c0a)
@kavon
Fix classification of non-generic noncopyables
ef54982 
We should not feature-guard types that use `~Copyable` only in an
inheritance clause.

(cherry picked from commit 6fc8123)
@kavon
Copy link
Member Author

kavon commented Apr 19, 2024

@swift-ci test

@kavon
Copy link
Member Author

kavon commented Apr 22, 2024

@swift-ci test

@kavon kavon enabled auto-merge April 22, 2024 18:17
@kavon kavon changed the title [6.0🍒] NCGenerics: omit flag in interfaces [6.0🍒] NCGenerics: permit syntax always Apr 22, 2024
@kavon
Copy link
Member Author

kavon commented Apr 22, 2024

windows failure had lots of this:

PermissionError: [WinError 5] Access is denied

@swift-ci please test windows

@kavon kavon merged commit d86a6ad into swiftlang:release/6.0 Apr 23, 2024
@kavon kavon deleted the 6.0-rdar126730410 branch April 23, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavon @tbkka