[6.0][Runtime] Fix CVW for genreic single payload enums with no extra inha… #73187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bitants rdar://126728925 When the payload of a generic SPE did not have any extra inhabitants, we erroneously always treated it as the no payload case. Additionally the offset and skip values were improperly computed.
|
@swift-ci test |
tbkka
approved these changes
Apr 22, 2024
|
@swift-ci test |
drexin
changed the title
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bitants
Explanation: When the payload of a generic SPE did not have any extra inhabitants, we erroneously always treated it as the no payload case. Additionally the offset and skip values were improperly computed.
Scope: Only affects compact value witnesses
Risk: Low. Only affects CVW
Testing: Added test cases
Issue: rdar://126728925
Reviewer: @mikeash
Main branch PR: #73186