[Test] Add swift_system_overlay_opt to %host-build-swift substitution #73224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-vfsoverlay` for system's modulemap is required for finding system clang modules in Windows.
|
@swift-ci Please test |
|
@swift-ci Please smoke test |
This was referenced Apr 24, 2024
rintaro
commented
Apr 24, 2024
| config.swiftc, | ||
| '' if kIsWindows else '-toolchain-stdlib-rpath', | ||
| mcp_opt, | ||
| config.swift_test_options, | ||
| config.swift_driver_test_options, | ||
| config.swift_system_overlay_opt, |
There was a problem hiding this comment.
this is empty in non-Windows platforms, defined at:
https://github.com/apple/swift/blob/3fe8b713d476dcbcf700588acf14f120ea5bfd21/test/lit.cfg#L379-L389
compnerd
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-vfsoverlayfor system's modulemap is required for finding system clang modules in Windows.