Skip to content

[Concurrency] Check varIsSafeAcrossActors in getActorIsolationForReference. #73279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

hborla
Copy link
Member

@hborla hborla commented Apr 26, 2024

Only treat nonisolated let properties in actors as isolated if access is from outside the module or the property type is notSendable.

Resolves: rdar://127018064

…olated

if access is from outside the module or the property type is not 'Sendable'.
@hborla
Copy link
Member Author

hborla commented Apr 26, 2024

@swift-ci please smoke test

@hborla hborla merged commit 9773e89 into swiftlang:main Apr 26, 2024
3 checks passed
@hborla hborla deleted the actor-nonisolated-let branch April 26, 2024 15:52
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants