Preliminary steps towards support for closures that capture pack element environments #73348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The discriminator assignment has since been split off into a separate thing, so all this does now is re-parent children of autoclosures.
We walk up the DeclContext hierarchy looking for closures, but they might not have had their types set yet because they're currently being type checked.
slavapestov
force-pushed
the
pack-expansion-closures-part-1
branch
from
f091f16 to
a480f8b
Compare
…mary environment I suspect there are latent bugs here with generic-class-constrained existentials, same-element requirements involving packs, etc. We can't assume that the local archetypes don't have "hidden" dependencies on the outer parameters that are not encoded in the thunk's interface type.
slavapestov
force-pushed
the
pack-expansion-closures-part-1
branch
from
a480f8b to
865b155
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just some NFC refactoring split off from a larger PR. The only notable thing is that CaptureInfo records a stack of GenericEnvironments now, but they're not used anywhere yet.