[ScanDependencies] Get accurate macro dependency #73421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
hborla,
slavapestov,
xedin and
artemcm
as code owners
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-127116512
branch
from
3bbf662 to
6907c02
Compare
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-127116512
branch
from
6907c02 to
cf20ccf
Compare
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-127116512
branch
from
cf20ccf to
2c7dbf1
Compare
|
@swift-ci please smoke test |
|
ping |
benlangmuir
reviewed
May 24, 2024
There was a problem hiding this comment.
Putting timestamps in the cache key seems really unfortunate; won't this miss any time you rebuild a macro plugin even if it hasn't changed (even if it's cached, the timestamp will change)? We had talked about using the binary UUID on mach-o; not sure if elf/coff has similar concepts; or we could hash the binary -- that might miss dynamic dependencies, but I suspect that's rare for macros.
|
The timestamp is a prototype that is not actually used in the actual logic. The idea is to find a better identity function when the plugin loader needs to actually verify the plugin status. |
cachemeifyoucan
force-pushed
the
eng/PR-127116512
branch
from
2c7dbf1 to
db7e4ea
Compare
|
@swift-ci please smoke test |
|
ping |
I'm not sure I understand -- isn't the implementation using timestamp right now? Are you saying this whole change is prototype, or what's the idea? |
It is a placeholder for future better implementation. The result of the timestamp is actually not used. I can sure remove it. |
cachemeifyoucan
force-pushed
the
eng/PR-127116512
branch
from
db7e4ea to
0384e36
Compare
|
@swift-ci please smoke test |
|
Oh, I might need to completely rewrite this after #73725 |
cachemeifyoucan
force-pushed
the
eng/PR-127116512
branch
3 times, most recently
from
bce2345 to
d4b8af9
Compare
|
@swift-ci please smoke test |
Build an accurate macro dependency for swift caching. Specifically, do not include not used macro plugins into the dependency, which might cause false negatives for cache hits. This also builds the foundation for future improvement when dependency scanning will determine the macro plugin to load and swift-frontend do not need to redo the work. rdar://127116512
cachemeifyoucan
force-pushed
the
eng/PR-127116512
branch
from
d4b8af9 to
4125e8c
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows platform |
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 8, 2024
Fix few issues from previous implementation from explicit module build with macros and accurate macro dependency scanning in swiftlang#73421. First, there is a crash when propagating the macro dependencies. It turns out that the current macro plugin implementation doesn't need the downstream users to know about the plugin search path from the upstream dependencies. Secondly, fix a bug that the swiftinterface that has macro usage won't build because the build command doesn't inherit the plugin search path option. Finally, add JSON output for macro dependencies so it is easier to debug the macro dependencies. rdar://131214106
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 8, 2024
Fix few issues from previous implementation from explicit module build with macros and accurate macro dependency scanning in swiftlang#73421. First, there is a crash when propagating the macro dependencies. It turns out that the current macro plugin implementation doesn't need the downstream users to know about the plugin search path from the upstream dependencies. Secondly, fix a bug that the swiftinterface that has macro usage won't build because the build command doesn't inherit the plugin search path option. Finally, add JSON output for macro dependencies so it is easier to debug the macro dependencies. rdar://131214106
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 9, 2024
Fix few issues from previous implementation from explicit module build with macros and accurate macro dependency scanning in swiftlang#73421. First, there is a crash when propagating the macro dependencies. It turns out that the current macro plugin implementation doesn't need the downstream users to know about the plugin search path from the upstream dependencies. Secondly, fix a bug that the swiftinterface that has macro usage won't build because the build command doesn't inherit the plugin search path option. Finally, add JSON output for macro dependencies so it is easier to debug the macro dependencies. rdar://131214106
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 11, 2024
Fix few issues from previous implementation from explicit module build with macros and accurate macro dependency scanning in swiftlang#73421. First, there is a crash when propagating the macro dependencies. It turns out that the current macro plugin implementation doesn't need the downstream users to know about the plugin search path from the upstream dependencies. Secondly, fix a bug that the swiftinterface that has macro usage won't build because the build command doesn't inherit the plugin search path option. Finally, add JSON output for macro dependencies so it is easier to debug the macro dependencies. rdar://131214106 (cherry picked from commit da10a02)
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 15, 2024
Fix few issues from previous implementation from explicit module build with macros and accurate macro dependency scanning in swiftlang#73421. First, there is a crash when propagating the macro dependencies. It turns out that the current macro plugin implementation doesn't need the downstream users to know about the plugin search path from the upstream dependencies. Secondly, fix a bug that the swiftinterface that has macro usage won't build because the build command doesn't inherit the plugin search path option. Finally, add JSON output for macro dependencies so it is easier to debug the macro dependencies. rdar://131214106 (cherry picked from commit da10a02)
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 16, 2024
Fix few issues from previous implementation from explicit module build with macros and accurate macro dependency scanning in swiftlang#73421. First, there is a crash when propagating the macro dependencies. It turns out that the current macro plugin implementation doesn't need the downstream users to know about the plugin search path from the upstream dependencies. Secondly, fix a bug that the swiftinterface that has macro usage won't build because the build command doesn't inherit the plugin search path option. Finally, add JSON output for macro dependencies so it is easier to debug the macro dependencies. rdar://131214106 (cherry picked from commit da10a02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build an accurate macro dependency for swift caching. Specifically, do not include not used macro plugins into the dependency, which might cause false negatives for cache hits.
This also builds the foundation for future improvement when dependency scanning will determine the macro plugin to load and swift-frontend do not need to redo the work.
rdar://127116512