Check if decl context returned by importDeclContextOf is null #74188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci smoke test |
beccadax
requested changes
Jun 6, 2024
Unfortunately I don't know how to test this. I only have a crash report from lldb which is crashing because |
I've seen a crash due to importDeclContextOf returning a null decl context in importAccessorParamsAndReturnType. Most other call sites of importDeclContextOf check the returned value, so add a check in importAccessorParamsAndReturnType too. rdar://127847162
augusto2112
force-pushed
the
null-decl-context
branch
from
503f487 to
fedf24c
Compare
|
@swift-ci smoke test |
beccadax
approved these changes
Jun 6, 2024
jefferyq2
pushed a commit
to jefferyq2/swift
that referenced
this pull request
Jun 10, 2024
Check if decl context returned by importDeclContextOf is null
jefferyq2
pushed a commit
to jefferyq2/swift
that referenced
this pull request
Jun 10, 2024
Check if decl context returned by importDeclContextOf is null
jefferyq2
pushed a commit
to jefferyq2/swift
that referenced
this pull request
Jun 10, 2024
Check if decl context returned by importDeclContextOf is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a crash due to
importDeclContextOfreturning a null decl context inimportAccessorParamsAndReturnType. Most other call sites ofimportDeclContextOfcheck the returned value, so add a check inimportAccessorParamsAndReturnTypetoo.rdar://127847162