[6.0][ScanDependencies] Make sure canImport resolution agrees with import
#74519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the problem that when the only module can be found is an invalid/out-of-date swift binary module, canImport and import statement can have different view for if the module can be imported or not. Now canImport will evaluate to false if the only module can be found for name is an invalid swiftmodule, with a warning with the path to the module so users will not be surprised by such behavior. rdar://128876895 (cherry picked from commit 7d85aa4)
|
@swift-ci please test |
nkcsgexi
approved these changes
Jun 18, 2024
cachemeifyoucan
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 18, 2024
#7647) (#7678) Explanation: This is a test-only change to allow for `canImport` change swiftlang/swift#74519 Scope: Test only. Update a test that relies on an invalid module as test input. Replace that with a swiftinterface. Original PR: #7647 Test: Unit-Test Reviewer: @tshortli
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix a problem where the error of cannot import module can be confusing when the only module can be found is an invalid/out-of-date swift binary module because
canImportandimportcan have different views on if the module can be import or not.Scope: Provide a better error message to help user understand the failure in such case and
canImportwill be evaluated to false when the "module" found is invalid.Issue: rdar://128876895
Original PR: #74199
Risk: Low
Test: Unit Test
Reviewer: @artemcm