[6.0][Modules] Avoid false swift module sharing #75134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
fredriss
approved these changes
Jul 10, 2024
cachemeifyoucan
changed the title
cachemeifyoucan
force-pushed
the
eng/PR-131408266-swift-6
branch
from
ce00aef to
88de8a9
Compare
|
@swift-ci please test |
When the swiftmodule is built with different clang importer arguments, they can have the same module hash, causing them to be wrongly re-used even they contains different interfaces. Add ReducedExtraArgs to the module hash to disambiguate them. However, some Xcc arguments, most commonly `-D` options do not affect the swiftmodule being generated. Do not pass `-Xcc -DARGS` to swift interface compilation to reduce the amount of module variants in the build. rdar://131408266 (cherry picked from commit a32dd95)
cachemeifyoucan
force-pushed
the
eng/PR-131408266-swift-6
branch
from
88de8a9 to
ecc5b6e
Compare
cachemeifyoucan
changed the title
|
@swift-ci please test |
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 15, 2024
Fix a memory leak from swiftlang#75134.
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 15, 2024
Fix a memory leak from swiftlang#75134. (cherry picked from commit d8c3ebd)
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 15, 2024
Fix a memory leak from swiftlang#75134.
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 15, 2024
Fix a memory leak from swiftlang#75134.
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 15, 2024
Fix a memory leak from swiftlang#75134. (cherry picked from commit 180e8d4)
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 16, 2024
Fix a memory leak from swiftlang#75134.
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 16, 2024
Fix a memory leak from swiftlang#75134.
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 16, 2024
Fix a memory leak from swiftlang#75134.
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 16, 2024
Fix a memory leak from swiftlang#75134. (cherry picked from commit ed93685)
cachemeifyoucan
added a commit
to cachemeifyoucan/swift
that referenced
this pull request
Jul 16, 2024
Fix a memory leak from swiftlang#75134. (cherry picked from commit ed93685)
susmonteiro
pushed a commit
that referenced
this pull request
Jul 19, 2024
Fix a memory leak from #75134.
|
Not merging this into 6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: When the swiftmodule is built with different clang importer arguments, they can have the same module hash, causing them to be wrongly re-used even they contains different interfaces.
Scope: Affect projects with the same swift module (interface) is imported by multiple modules with different clang importer args.
Issue: rdar://131408266
Original PR: #75133
Reviewer: @artemcm
Risk: Low. It can cause slow down in projects with such false sharing but the most common cases where
-Xcc -Dis used, it should not be a problem.Test: UnitTest