Accommodate 64-bit clang serialization IDs #75513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several serialization IDs that used to be 32 bits are being widened to 64. Modify SwiftLookupTable and its supporting types to accommodate this. The new design uses a 64-bit integer for the pointer, decl, macro, or identifier ID, plus a 32-bit integer for the submodule ID (this field is set to all ones to indicate a decl vs. a macro). An additional in-memory bool distinguishes pointer nodes from ID nodes. Advantages: • The main ID is now 64 bits wide, accommodating recent changes in clang. • We’re no longer stealing bits from clang (we *do* steal the max value of the submodule ID, though). • There’s no on-disk bit that, when set, will cause an ID to be interpreted as a pointer. • Design is robust against `clang::serialization::SubmoduleID` also becoming 64-bit (although this will waste space). Fixes rdar://131134424.
beccadax
requested review from
zoecarver,
hyp,
egorzhdan and
ian-twilightcoder
as code owners
|
With swiftlang/llvm-project#9017 @swift-ci please test |
shahmishal
requested review from
rjmccall,
artemcm,
ahoppen,
bnbarham,
hamishknight,
rintaro,
xymus,
tshortli,
adrian-prantl,
eeckstein,
DougGregor,
slavapestov,
hborla,
xedin and
jckarter
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several serialization IDs that used to be 32 bits are being widened to 64. Modify SwiftLookupTable and its supporting types to accommodate this.
The new design uses a 64-bit integer for the pointer, decl, macro, or identifier ID, plus a 32-bit integer for the submodule ID (this field is set to all ones to indicate a decl vs. a macro). An additional in-memory bool distinguishes pointer nodes from ID nodes. Advantages:
clang::serialization::SubmoduleIDalso becoming 64-bit (although this will waste space).This will require a matching clang PR to revert the revert of the ID change: swiftlang/llvm-project#9017
Fixes rdar://131134424.