[Serialization] Do not serialize unstable hashes #75876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm/llvm-project#96282 changed `get_execution_seed` to be non-deterministic. Use stable hashes instead.
bnbarham
requested review from
xymus,
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
bnbarham
commented
Aug 14, 2024
| @@ -71,7 +71,7 @@ class LocalizationWriterInfo { | |||
| using hash_value_type = uint32_t; | |||
| using offset_type = uint32_t; | |||
|
|
|||
| hash_value_type ComputeHash(key_type_ref key) { return llvm::hash_code(key); } | |||
There was a problem hiding this comment.
Note that this is a no-op - it was converting to 64 bits and then back to 32 bit. I was just here because I looked for all serialization tables 😅 . Seems worth changing since hash_code is a Hashing.h type.
| @@ -330,7 +330,7 @@ class ModuleFileSharedCore::DeclMembersTableInfo { | |||
| } | |||
|
|
|||
| hash_value_type ComputeHash(internal_key_type key) { | |||
| return llvm::hash_value(key); | |||
| return key; | |||
There was a problem hiding this comment.
hash_value ends up calling getHashValue and for a uint32_t that was just val * 37. Happy to change it to that, to reinterpret_cast then djbHash, or just leave it like this - let me know!
xedin
approved these changes
Aug 14, 2024
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#96282 changed
get_execution_seedto be non-deterministic. Use stable hashes instead.