[ClangImporter][ModuleWrap] Turn off libc warnings. #76545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`swift-modulewrap` uses the `ClangImporter` to obtain a module loader, but it doesn't take an SDK argument (nor does anything bother to pass one), which means that when cross-compiling you get warnings about not being able to find the C library. Suppress the warning by telling the `ClangImporter` that we don't care about the C library here. rdar://115918181
al45tair
requested review from
artemcm,
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci Please test |
egorzhdan
reviewed
Sep 18, 2024
|
Hmmm. Maybe I should make it try to set up the file mapping and just not fail the same way, rather than turning it off completely. (I'm not sure whether it might need C/C++ symbols; it plainly doesn't for the things I've tried with the Static SDK, and I think this problem happens for other cross-compilation situations too, but I'm not confident enough that I'm entirely comfortable.) |
We should still try adding the overlays, even if we're asked not to generate a diagnostic while doing so. That's slightly safer because it means that we're less likely to find ourselves in a situation where `swift-modulewrap` wants to use types from the C/C++ library and can't. rdar://115918181
|
@swift-ci Please test |
egorzhdan
approved these changes
Sep 30, 2024
|
@swift-ci Please smoke test macOS platform |
|
macOS test failure isn't related to this PR, as far as I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-modulewrapuses theClangImporterto obtain a module loader, but it doesn't take an SDK argument (nor does anything bother to pass one), which means that when cross-compiling you get warnings about not being able to find the C library.Suppress the warning by telling the
ClangImporterthat we don't care about the C library here.rdar://115918181