Skip to content

[Concurrency] add comment about bug causing Sendable conformance test… #77326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sophiapoirier
Copy link
Contributor

… case to be error rather than warning (follow up to e8d9804)

… case to be error rather than warning (follow up to e8d9804)
@sophiapoirier sophiapoirier requested a review from hborla October 31, 2024 18:56
@sophiapoirier sophiapoirier requested a review from ktoso as a code owner October 31, 2024 18:56
@sophiapoirier
Copy link
Contributor Author

addressing request by @hborla

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sophiapoirier
Copy link
Contributor Author

@swift-ci please test

@sophiapoirier
Copy link
Contributor Author

@swift-ci please test macOS

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the note, maybe issue would be good to go with it. unless it's tracked perhaps somewhere already :)

@hborla
Copy link
Member

hborla commented Nov 1, 2024

maybe issue would be good to go with it. unless it's tracked perhaps somewhere already :)

I have issues for this that I'm working on! I'm using #76652 for the @preconcurrency downgrade bugs.

@sophiapoirier sophiapoirier merged commit c9cb122 into swiftlang:main Nov 1, 2024
5 checks passed
@sophiapoirier sophiapoirier deleted the preconcurrency_import_warning_for_suppressed_sendable_diagnostic_comment branch November 1, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants