Skip to content

[6.1] Fix source break with invalid nonisolated lazy properties #78469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

slavapestov
Copy link
Contributor

6.1 cherry-pick of #78468 and #77690

  • Description: Swift 6.0 allowed nonisolated lazy properties to be declared, which opens a data race. This was made into an error in Concurrency: Reject nonisolated lazy properties #76518 but it should be a warning until -swift-version 6.
  • Origination: New regression in 6.1 branch.
  • Scope of the issue: Affected a few projects.
  • Risk: Low, only changes behavior in an existing error path.
  • Reviewed by: @hborla
  • Radar: rdar://141967932 was the latest iteration

@slavapestov slavapestov requested a review from a team as a code owner January 7, 2025 18:37
…id on 'lazy'

Otherwise, we'll in turn complain if the nonisolated lazy property was
@objc. This is also invalid, but the goal here is to avoid the source
break until -swift-version 6.

Fixes rdar://141967932.
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov slavapestov merged commit b579a9e into swiftlang:release/6.1 Jan 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants