🍒 Linux: don't link libicu in static executables, as it is no longer built separately #79274
Conversation
…ilt separately This was dropped in swiftlang#40340. (cherry picked from commit abe9225)
|
@swift-ci please test |
|
@stephentyrone, mind reviewing? |
|
@finagolfin Thanks! |
|
Ping @shahmishal, simple fix for linux. |
|
Please include these details in the PR: https://github.com/swiftlang/.github/blob/main/PULL_REQUEST_TEMPLATE/release.md?plain=1 |
|
Oh, right, will do. |
finagolfin
added
🍒 release cherry pick
|
Explanation: These icu libraries were removed in #40340, but we missed that this static executable linker file still listed them. Scope: Only affects linking static executables for linux Issue: #79153 Original PR: #78678 Risk: None Testing: Passed all CI on trunk and the bug reporter said it worked Reviewer: @stephentyrone @rjmansfield, just a tip that the release branches require this info, forgot to tell you before. |
|
@finagolfin Thanks, sorry I didn't know. |
|
Pinging @bnbarham, simple fix for 6.1 on linux. |
This was dropped in #40340.
(cherry picked from commit abe9225)
Fixes Issue #79153 on 6.1