[DependencyScan] Use llvm::DefaultThreadPool instead of llvm::StdThreadPool
#79341
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hreadPool` `llvm::StdThreadPool` is only available when LLVM_ENABLE_THREADS is enabled. LLVM defines `DefaultThreadPool` type alias, which is always available regardless of the threads enabled. This change allows building the library without threads enabled, especially for Emscripten toolchain. ``` #if LLVM_ENABLE_THREADS using DefaultThreadPool = StdThreadPool; #else using DefaultThreadPool = SingleThreadExecutor; #endif ```
kateinoigakukun
requested review from
artemcm and
cachemeifyoucan
as code owners
|
@swift-ci smoke test |
37 tasks
cachemeifyoucan
approved these changes
Feb 13, 2025
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::StdThreadPoolis only available when LLVM_ENABLE_THREADS is enabled. LLVM definesDefaultThreadPooltype alias, which is always available regardless of the threads enabled. This change allows building the library without threads enabled, especially for Emscripten toolchain.