Skip to content

[SILOptimizer] Don't apply CMO to key paths that reference inaccessib… #79506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Feb 20, 2025

…le properties

rdar://145095088

@drexin drexin requested a review from eeckstein as a code owner February 20, 2025 01:13
@drexin
Copy link
Contributor Author

drexin commented Feb 20, 2025

@swift-ci smoke test

@slavapestov
Copy link
Contributor

Please add a test case.

@drexin
Copy link
Contributor Author

drexin commented Feb 20, 2025

Please add a test case.

Yes, I am working on it. I have been unable to reproduce the issue in a test case so far.

@drexin drexin marked this pull request as draft February 20, 2025 06:15
@drexin drexin marked this pull request as ready for review February 25, 2025 06:35
@drexin
Copy link
Contributor Author

drexin commented Feb 25, 2025

@swift-ci smoke test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drexin drexin merged commit f5dd557 into swiftlang:main Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants