Skip to content

6.1: Check file type better in this verifier. #79868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Mar 8, 2025

Explanation: Fix check in asserts-only verifier that determines whether a decl comes from a SIL source file.
Scope: Affects test files written in textual SIL tested using an asserts compiler.
Issue: rdar://147359465
Original PR: #79586
Risk: None.
Testing: CI.
Reviewer: Arnold Schwaighofer ( @aschwaighofer )

Ask the decl directly whether its source file is a sil source file.
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler marked this pull request as ready for review March 21, 2025 20:08
@nate-chandler nate-chandler requested a review from a team as a code owner March 21, 2025 20:08
@nate-chandler nate-chandler enabled auto-merge March 21, 2025 21:13
@nate-chandler nate-chandler merged commit 1e211b4 into swiftlang:release/6.1 Mar 22, 2025
5 checks passed
@nate-chandler nate-chandler deleted the cherrypick/release/6.1/rdar145035291 branch March 22, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants