[WIP] Fix https://github.com/swiftlang/swift/issues/80014 #80088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolas-pohilets
requested review from
ktoso,
eeckstein and
jckarter
as code owners
slavapestov
reviewed
Mar 28, 2025
| @@ -1247,7 +1247,12 @@ SILType SILType::removingAnyMoveOnlyWrapping(const SILFunction *fn) { | |||
| } | |||
|
|
|||
| bool SILType::isSendable(SILFunction *fn) const { | |||
| return getASTType()->isSendableType(); | |||
| switch (getCategory()) { | |||
There was a problem hiding this comment.
This is going to change the behavior of other existing callers in the compiler. I'm also not convinced this is necessary. Whether a type is loadable or address-only is an implementation detail of the type and should not be observable in the language semantics in any way.
|
Superseded by #80745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing tests:
Note sure how to implement logic from 7c45c7d.