[Concurrency] Fix task status and private storage sizes. #80447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveTaskStatusSize is 2 words, not 4, on most targets. PrivateStorageSize is measured in bytes, not words, so the Storage field needs to be a char[].
|
@swift-ci please test |
|
This fix exposed an issue with task child iteration in ReflectionContext. Adding a fix for that here, plus a better test. |
|
@swift-ci please test |
|
And this needs a new entry in |
|
@swift-ci please test |
|
@swift-ci please test macos platform |
al45tair
approved these changes
Apr 8, 2025
ktoso
approved these changes
Apr 8, 2025
Iterating child tasks depends on knowing the size of AsyncTask, and changing the size of the task broke it. Instead of relying on mirroring the full structure in our out-of-process definitions, add a debug variable to libswift_Concurrency that contains the size of AsyncTask. While we're there, add some more validation to child task enumeration. Check each child task's metadata pointer to make sure that it actually points to the AsyncTask metadata, and have the inner loop also increment and check ChildTaskLoopCount to stop runaway iteration in that loop.
|
@swift-ci please test |
grynspan
reviewed
Apr 14, 2025
| static void | ||
| indented_printf(unsigned indentLevel, const char *fmt, ...) { | ||
| for (unsigned i = 0; i < indentLevel; i++) | ||
| fputs(" ", stdout); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveTaskStatusSize is 2 words, not 4, on most targets.
PrivateStorageSize is measured in bytes, not words, so the Storage field needs to be a char[].
rdar://148836760