Skip to content

Unconditionally add -z,origin on OpenBSD. #80897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

3405691582
Copy link
Member

This is a little less than ideal, since as I understand it, it only makes sense to add -z,origin when $ORIGIN expansion is required, but doing this surgically per target is rather cumbersome. I don't believe there are any significant drawbacks to doing it unconditionally like this, however.

This is a little less than ideal, since as I understand it, it only makes
sense to add -z,origin when $ORIGIN expansion is required, but doing this
surgically per target is rather cumbersome. I don't believe there are any
significant drawbacks to doing it unconditionally like this, however.
@3405691582
Copy link
Member Author

@swift-ci please smoke test.

@3405691582
Copy link
Member Author

@swift-ci please test Windows platform

Copy link
Member

@finagolfin finagolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only affects OpenBSD, so should be fine.

@3405691582
Copy link
Member Author

Please merge on my behalf if there's nothing else needed, thanks!

@finagolfin finagolfin merged commit 79e0b6a into swiftlang:main Apr 30, 2025
3 checks passed
3405691582 added a commit to 3405691582/swift that referenced this pull request May 1, 2025
This is a little less than ideal, since as I understand it, it only
makes sense to add -z,origin when $ORIGIN expansion is required, but
doing this surgically per target is rather cumbersome. I don't believe
there are any significant drawbacks to doing it unconditionally like
this, however.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants