[cxx-interop] Avoid querying layout of dependent types during symbolic import #81228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-hui
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please test |
|
I'm also going to re-enable the benchmarks that were disabled in #81145. |
…c import In swiftlang#80786, we started importing certain padded fields as opaque blobs. Part of this logic involved querying those fields' ASTRecordLayout. However, dependent types (which are imported symbolically) do not have an ASTRecordLayout, so calling Clang's getASTRecordLayout() would lead to an assertion error for class templates where a no_unique_address field is some kind of dependent C++ record type. This patch avoids the field padding check during symbolic import mode because that check is only relevant for codegen anyway. rdar://150067288
…k from the build (swiftlang#81145)" This reverts commit 86c30d6.
j-hui
force-pushed
the
fix-ast-layout-dependent-types
branch
from
4818e7e to
ff596d5
Compare
|
@swift-ci please test |
|
@swift-ci please benchmark |
|
@swift-ci please benchmark linux platform |
Xazax-hun
reviewed
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #80786, we started importing certain padded fields as opaque blobs.
Part of this logic involved querying those fields' ASTRecordLayout.
However, dependent types (which are imported symbolically) do not have
an ASTRecordLayout, so calling Clang's getASTRecordLayout() would lead
to an assertion error for class templates where a no_unique_address
field is some kind of dependent C++ record type.
This PR includes a patch that avoids the field padding check during symbolic import mode
because that check is only relevant for codegen anyway.
This PR also includes some small test case updates to increase coverage of padded fields other than
std::optional.rdar://150067288