[cxx-interop] Disabling should be annotated with SWIFT_RETURNS_(UN)RETAINED warning #81411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TAINED warning rdar://150937617
|
@swift-ci please smoke test |
fahadnayyar
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
|
fwiw I was seeing this on Ladybird as well: https://gist.github.com/ADKaster/0fb9a20076718fee3ad11305635075b8 (swiftly main-snapshot-2025-04-30) None of my types are actually SWIFT_SHARED_REFERENCE: They are all (or should be all, due to an ancestor base class being) SWIFT_UNSAFE_REFERENCE. In theory this means 'memory not managed by swift, but by my custom GC/memory strategy', so the 32k lines of diagnostics suggesting to add the SWIFT_RETURNS_(UN)RETAINED annotations is unwelcome. |
Catfish-Man
pushed a commit
that referenced
this pull request
May 15, 2025
…TAINED warning (#81411) In Swift 6.1, we introduced warnings for C++ APIs returning SWIFT_SHARED_REFERENCE types that lack the SWIFT_RETURNS_(UN)RETAINED annotations. These warnings serve as a reminder to annotate APIs, as the absence of these annotations can lead to arbitrary assumptions about the ownership of returned SWIFT_SHARED_REFERENCE values. This could result in both use-after-free (memory safety) bugs and memory leaks. We have received feedback from a few adopters indicating potential false positive cases where these warnings are triggered. Consequently, we have decided to disable these warnings in Swift 6.2 and re-qualify the warnings on larger projects to ensure their effectiveness and eliminate false positives. Our intention is to re-enable the warnings in later beta releases of Swift 6.2 once we have stronger evidence of their effectiveness on large codebases and proof that there are no false positives. rdar://150937617 rdar://150800115
fahadnayyar
added a commit
to fahadnayyar/swift
that referenced
this pull request
Jun 25, 2025
…S_(UN)RETAINED warning (swiftlang#81411)" This reverts commit 49aea31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift 6.1, we introduced warnings for C++ APIs returning SWIFT_SHARED_REFERENCE types that lack the SWIFT_RETURNS_(UN)RETAINED annotations. These warnings serve as a reminder to annotate APIs, as the absence of these annotations can lead to arbitrary assumptions about the ownership of returned SWIFT_SHARED_REFERENCE values. This could result in both use-after-free (memory safety) bugs and memory leaks.
We have received feedback from a few adopters indicating potential false positive cases where these warnings are triggered. Consequently, we have decided to disable these warnings in Swift 6.2 and re-qualify the warnings on larger projects to ensure their effectiveness and eliminate false positives. Our intention is to re-enable the warnings in later beta releases of Swift 6.2 once we have stronger evidence of their effectiveness on large codebases and proof that there are no false positives.
rdar://150937617
rdar://150800115