[SILGen] Fix the type of closure thunks that are passed const reference structs #82486
+333
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
xymus,
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
jckarter,
beccadax,
ian-twilightcoder,
hborla,
slavapestov and
xedin
as code owners
hnrklssn
reviewed
Jun 26, 2025
hnrklssn
reviewed
Jun 26, 2025
hnrklssn
reviewed
Jun 26, 2025
hnrklssn
reviewed
Jun 26, 2025
Xazax-hun
force-pushed
the
gaborh/const-ref-crash
branch
2 times, most recently
from
90b2629 to
e0f7524
Compare
…ce structs This PR is another attempt at landing #76903. The changes compared to the original PR: * Instead of increasing the size of SILDeclRef, store the necessary type information in the conversion AST nodes. * The PR above introduced a crash during indexing system modules that references foreign types coming from modules imported as implementation only. These entities are implementation details so they do not need to be included during serialization. This PR adds a test and adds logic to exclude such clang types in the serialization process. rdar://131321096&141786724
Xazax-hun
force-pushed
the
gaborh/const-ref-crash
branch
from
e0f7524 to
17522c4
Compare
|
@swift-ci please smoke test |
hnrklssn
approved these changes
Jun 27, 2025
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another attempt at landing #76903. The changes compared to the original PR:
rdar://131321096&141786724