[cxx-interop] Allow import-as-member for functions declared within a namespace #82579
+23
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/import-as-member-from-namespace
branch
from
0efd534 to
9603bd2
Compare
|
@swift-ci please smoke test |
hnrklssn
approved these changes
Jun 30, 2025
|
@swift-ci please test Windows |
Xazax-hun
approved these changes
Jul 2, 2025
lib/ClangImporter/ImportDecl.cpp
Outdated
| @@ -10231,7 +10231,9 @@ ClangImporter::Implementation::importDeclContextOf( | |||
|
|
|||
| // If the declaration was not global to start with, we're done. | |||
| bool isGlobal = | |||
There was a problem hiding this comment.
Nit: I think this code is a bit confusing. isGlobal to me suggest something like DeclContext::isFileContext. But the fact that we also make this condition dependent on the EffectiveClangContext suggests me that the meaning of this is a bit more elaborate. Should this be something like isRenamedGlobal?
There was a problem hiding this comment.
Good point! Renamed it to isRenamedGlobal.
…namespace This makes it possible to use trigger import-as-member for C++ functions declared within namespaces. Previously only functions declared at the file level were supported. rdar://138930205
egorzhdan
force-pushed
the
egorzhdan/import-as-member-from-namespace
branch
from
9603bd2 to
d3dc17a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use trigger import-as-member for C++ functions declared within namespaces. Previously only functions declared at the file level were supported.
rdar://138930205