Support LLVM optimization remarks in WMO mode #82646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschwaighofer
requested review from
artemcm,
tshortli,
rjmccall,
jckarter,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
| } | ||
|
|
||
| auto auxRS = std::make_unique<llvm::remarks::RemarkStreamer>( | ||
| std::move(*remarkSerializerOrErr), filename); |
There was a problem hiding this comment.
Could we set the filter here according to the passed command line argument (similar to
swift/lib/SIL/Utils/SILRemarkStreamer.cpp
Line 85 in d203591
Comment on lines
1200
to
1203
| if (IGM.getOptions().AnnotateCondFailMessage) { | ||
| Context.setLLVMRemarkStreamer( | ||
| std::make_unique<llvm::LLVMRemarkStreamer>(RS)); | ||
| // FIXME: add a frontend flag to enable all LLVM remarks | ||
| cantFail(RS.setFilter("annotation-remarks")); | ||
| } else { |
There was a problem hiding this comment.
Since we just enable the LLVM remarks by default for now, I think we should remove this branch/filter entirely, otherwise we filter for annotation remarks in the main file only, but not in the aux files.
aschwaighofer
force-pushed
the
wip_opt_remarks_wmo
branch
from
b1edbac to
5c7e017
Compare
|
@swift-ci test |
…es in WMO mode rdar://154403078
aschwaighofer
force-pushed
the
wip_opt_remarks_wmo
branch
from
5c7e017 to
b30bd40
Compare
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to create llvm::RemarkStreamer objects for all the LLVMModules in WMO mode.
This way we can collect optimization remarks from the LLVM optimizer and backend.
rdar://154403078