[cxx-interop] Support types nested in extensions #82712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated header did not compile due to a bug that prevented us from referencing the correct namespaces derived from the nominal type's name (an extension does not have a name). Moreover, we did not generate forward declarations for the members of the extensions for classes and enums (but we did for structs). This change also removes a workaround that emitted String::Index as _String_Index. rdar://153221450
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated header did not compile due to a bug that prevented us from referencing the correct namespaces derived from the nominal type's name (an extension does not have a name). Moreover, we did not generate forward declarations for the members of the extensions for classes and enums (but we did for structs). This change also removes a workaround that emitted String::Index as _String_Index.
rdar://153221450