Skip to content

[NFC][windows] add named arguments to Copy-Item calls in build.ps1 #83517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

[NFC][windows] add named arguments to Copy-Item calls in build.ps1 #83517

merged 1 commit into from
Aug 5, 2025

Conversation

charles-zablit
Copy link
Contributor

This NFC adds named arguments to Copy-Item calls in build.ps1 (-Path and -Destination).

@charles-zablit charles-zablit self-assigned this Aug 4, 2025
@charles-zablit charles-zablit added Windows Platform: Windows nfc Flag: No Functional Change labels Aug 4, 2025
@charles-zablit
Copy link
Contributor Author

@swift-ci please test

@charles-zablit charles-zablit mentioned this pull request Aug 4, 2025
Open
@compnerd compnerd enabled auto-merge August 4, 2025 15:48
@charles-zablit charles-zablit force-pushed the charles-zablit/windows/cleanup-named-arguments-build.ps1 branch from 771c906 to 3c7384e Compare August 5, 2025 09:55
@charles-zablit
Copy link
Contributor Author

@swift-ci please test

@charles-zablit
Copy link
Contributor Author

@compnerd I'm not sure what I did, but I might have pushed my changes on the wrong branch somehow. 3c7384e contains my intended changes, i.e adding -Path and -Destination to every Copy-Item calls.

@compnerd compnerd merged commit e9f19fc into swiftlang:main Aug 5, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees

@charles-zablit charles-zablit

Labels
nfc Flag: No Functional Change Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charles-zablit @compnerd