-
Notifications
You must be signed in to change notification settings - Fork 51
Add lock to ensure only one Swiftly process is running at any point #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I encountered this also while running |
@adam-fowler Can I work on this issue? |
I'm not really that involved in the swiftly project anymore. @cmcgee1024 can make a call on that. |
@roulpriya I don't think that anyone else is working on this at the moment. I'm assigning this to you to indicate that you're taking a look at it right now. |
@cmcgee1024 I came across how SwiftPM implements locking. When we try to execute multiple instances of SwiftPM we get a log like In Swiftly, should we wait to acquire the lock or print an error and exit? |
In my opinion lock acquisition should exit immediately with a specific exit code that scripts (or VSCode) can check and decide on their polling, and/or timeout strategy. Those things will have a better understanding of their environment, and the constraints. The proxies, and |
* Issue #142 Implement non-blocking file lock * Add lock in uninstall * Use atomic create for lock * Adding FileLock Tests
Running two swiftly processes at the same produces undefined results.
We should add a file lock to ensure only one swiftly process is touching the swiftly folder structure at any one point
The text was updated successfully, but these errors were encountered: