Skip to content

2 warning popups when changing toolchain #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
award999 opened this issue Mar 31, 2025 · 1 comment
Closed

2 warning popups when changing toolchain #1471

award999 opened this issue Mar 31, 2025 · 1 comment
Assignees
@award999
Labels
bug Something isn't working

Comments

@award999
Copy link
Contributor

Describe the bug
When changing the selected version of Xcode using the Swift: Select Toolchain... command, you get prompted with 2 warning about needing to reload the extension. Little annoying

Image

To Reproduce
Steps to reproduce the behavior:

  1. Run the command and select a different Xcode installation

Expected behavior
Should ideally only have one warning popup

Environment

  • OS: macOS
  • Swift version: N/A
  • Visual Studio Code version: N/A
  • vscode-swift version: N/A

Additional context
N/A
@award999 award999 added the bug Something isn't working label Mar 31, 2025
plemarquand added a commit to plemarquand/vscode-swift that referenced this issue Mar 31, 2025
@plemarquand
Ensure only one reload extension dialog can be shown at a time
3c74b28 
If `showReloadExtensionNotification` is in flight and being awaited then
return the promise being awaited instead of showing another dialog.

Also, debounce `showReloadExtensionNotification` with a 5 second window
because its possible for users to close the first dialog very fast and
have another one appear immediately if we update several settings at a
time that require an extension restart.

Issue: swiftlang#1471
@plemarquand plemarquand mentioned this issue Mar 31, 2025
Merged
@plemarquand plemarquand self-assigned this Mar 31, 2025
plemarquand added a commit that referenced this issue Mar 31, 2025
@plemarquand
Ensure only one reload extension dialog can be shown at a time (#1473)
7e92f4c 
If `showReloadExtensionNotification` is in flight and being awaited then
return the promise being awaited instead of showing another dialog.

Also, debounce `showReloadExtensionNotification` with a 5 second window
because its possible for users to close the first dialog very fast and
have another one appear immediately if we update several settings at a
time that require an extension restart.

Issue: #1471
@award999 award999 added the needs verification Issue has been fixed, but requires verification before closing label Apr 2, 2025
@award999 award999 assigned award999 and unassigned plemarquand Apr 2, 2025
@award999 award999 moved this from Unscreened to Needs Verification in Swift Extension for Visual Studio Code Apr 2, 2025
@award999
Copy link
Contributor Author

award999 commented Apr 2, 2025

Verified with 38db866

@award999 award999 closed this as completed Apr 2, 2025
@award999 award999 removed the needs verification Issue has been fixed, but requires verification before closing label Apr 2, 2025
@award999 award999 moved this from Needs Verification to Done in Swift Extension for Visual Studio Code Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@award999 award999

Labels
bug Something isn't working
Projects
Swift Extension for Visual Studio Code
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plemarquand @award999