Properly cleanup task event emitters #1593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
award999
commented
May 30, 2025
award999
commented
- Were not displosing of event emitters
- Were cleaning up read-only process data listeners early
- Were not displosing of event emitters - Were cleaning up read-only process data listeners early
award999
added
the
full-test-run
plemarquand
changed the title
plemarquand
approved these changes
May 30, 2025
award999
force-pushed
the
nightly-failures
branch
from
82800dc to
df842a2
Compare
award999
force-pushed
the
nightly-failures
branch
from
df842a2 to
6f83698
Compare
rbenegal
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.