Improve error reporting when SourceKit-LSP fails to start #982
Conversation
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
|
Here is a screen recording of the current behaviour when SourceKit-LSP fails to start due to a bad argument. |
plemarquand
force-pushed
the
better-sourcekit-init-error
branch
from
33efc2a to
c1eff30
Compare
|
Here is the new dialog (well, same as the old dialog, except it sticks around and you can read it). 
Here is the output you see when you click "Go to Output". The error is not automatically highlighted, that is just to show that the error is now properly reported. 
|
plemarquand
force-pushed
the
better-sourcekit-init-error
branch
from
c1eff30 to
1fffbb6
Compare
If SourceKit-LSP fails to initialize, typically because of unrecognized launch arguments, don't attempt to restart it and limit the number of erorr dialogs to just one descriptive one. Clicking the "Go to Output" button on this dialog takes you to the SourceKit-LSP Output panel which now shows the SourceKit-LSP launch error. Issue: swiftlang#976
There was a problem hiding this comment.
The bits of this PR that work seem to be about ensuring the error handler doesn't try to restart the server if initialisation failed. Which already makes things clearer as you get a dialog saying there was an issue go to the LSP output to find out what it was.
The parts which attempt to parse the log don't seem to get called. Maybe you could move them to the error handler instead of in the catch block.
plemarquand
force-pushed
the
better-sourcekit-init-error
branch
from
1fffbb6 to
06af591
Compare
|
Verified |
If SourceKit-LSP fails to initialize, typically because of unrecognized launch arguments, don't attempt to restart it and limit the number of erorr dialogs to just one descriptive one. Clicking the "Go to Output" button on this dialog takes you to the SourceKit-LSP Output panel which now shows the SourceKit-LSP launch error.