Update static.zip, automate its release process #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestApp/Package.swift
Outdated
| @@ -9,7 +9,7 @@ let package = Package( | |||
| .executable(name: "TestApp", targets: ["TestApp"]), | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/kateinoigakukun/JavaScriptKit", .revision("85b8617")), | |||
| .package(url: "https://github.com/kateinoigakukun/JavaScriptKit", .revision("c90e82f")), | |||
| ], | |||
| targets: [ | |||
| // Targets are the basic building blocks of a package. A target can define a module or a test suite. | |||
There was a problem hiding this comment.
- 🚫 Line should be 100 characters or less: currently 104 characters (
line_length)
Generated by 🚫 Danger Swift against 8968d42 |
carson-katri
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev.jsentrypoint has been updated to include the recent JavaScriptKit runtime fix: swiftwasm/JavaScriptKit#19I've also added a new subcommand to
carton-release, which is now able to automaticallly create a newstatic.zipand record updated hashes in the source code. It still doesn't upload the archive automatically to previous release assets, but I wonder if that should be done manually anyway, at least until we have some kind of tests that verify the whole process end-to-end.Additionally, since the new runtime is not compatible with the old Swift parts of JavaScriptKit,
carton devnow checks the revision of JavaScriptKit that projects have specified in theirPackage.swift. It doesn't block the build process, but I hope it gives enough warning about the incompatibility.