Skip to content

Font awesome height li #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
babajem opened this issue Mar 8, 2018 · 1 comment
Closed

Font awesome height li #610

babajem opened this issue Mar 8, 2018 · 1 comment
Labels
Bug

Comments

@babajem
Copy link

babajem commented Mar 8, 2018

Hello

When I use some font awesome icons, the height of li is smaller.

You can even see it in the documentation :
https://swisnl.github.io/jQuery-contextMenu/demo.html
26.38px
https://swisnl.github.io/jQuery-contextMenu/demo/fontawesome-icons.html
22.38px

I search and the problem come from line-height inside .fa{} declaration

so you just have to add :
.context-menu-icon.context-menu-icon--fa { line-height: inherit; }
@bbrala bbrala added the Bug label Mar 9, 2018
bbrala added a commit that referenced this issue Mar 16, 2018
@bbrala
Font awesome li height is now consistent again. Fixes issue #610
263a054
@bbrala
Copy link
Member

bbrala commented Mar 16, 2018

Fixed, thanks for the report.

@bbrala bbrala closed this as completed Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbrala @babajem