Skip to content

Visible fires twice #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nigelmclaughlin opened this issue Mar 13, 2018 · 2 comments
Closed

Visible fires twice #612

nigelmclaughlin opened this issue Mar 13, 2018 · 2 comments
Labels
2.x 3.x Bug

Comments

@nigelmclaughlin
Copy link

nigelmclaughlin commented Mar 13, 2018 •
edited
Loading

I've tried this with even just a single list item and it seems that the visble() function always fires twice - this behaviour also occurs in V3 Beta.

This is pretty problematic when using Ajax calls to determine whether an item should be visible / invisible as it makes 2 trips to the Ajax call.
@bbrala bbrala added the Bug label Mar 13, 2018
@bbrala
Copy link
Member

bbrala commented Mar 13, 2018

Yeah that is rather nasty indeed. Thanks for the report.

bbrala added a commit that referenced this issue Mar 16, 2018
@bbrala
The contextmenu now checks visible on items once instead of twice.
6911d4b 
The menu checked `visible` status twice, once to check if the menu should be opened and once more when the menu was opened. The logic all moved to the `show` method now so the check is only done once. This should fix issue #612
bbrala added a commit that referenced this issue Mar 16, 2018
@bbrala
The contextmenu now checks visible on items once instead of twice.
c0e859e 
The menu checked `visible` status twice, once to check if the menu should be opened and once more when the menu was opened. The logic all moved to the `show` method now so the check is only done once. This should fix issue #612
bbrala added a commit that referenced this issue Mar 16, 2018
@bbrala
The contextmenu now checks visible on items once instead of twice.
55c2e42 
The menu checked `visible` status twice, once to check if the menu should be opened and once more when the menu was opened. The logic all moved to the `show` method now so the check is only done once. This should fix issue #612
This was referenced Mar 16, 2018
Merged
Merged
@bbrala
Copy link
Member

bbrala commented Mar 16, 2018

The menu checked visible status twice, once to check if the menu should be opened and once more when the menu was opened. The logic all moved to the show method now so the check is only done once.

Thanks again for the report.

@bbrala bbrala closed this as completed Mar 16, 2018
bbrala added a commit that referenced this issue Mar 16, 2018
@bbrala
Font awesome li height is now consistent again. Fixes issue #612
d83e7aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x 3.x Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbrala @nigelmclaughlin