Skip to content

Fix exceptions to use sprintf for string formatting #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

OskarStark
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Docs? no
Issues --
License MIT

Replace string concatenation and interpolation with sprintf in all exception messages for consistency and better formatting.

@carsonbot carsonbot changed the title Fix exceptions to use sprintf for string formatting Fix exceptions to use sprintf for string formatting Aug 20, 2025
@OskarStark OskarStark requested a review from fabpot August 20, 2025 12:09
@OskarStark OskarStark force-pushed the fix-exception-sprintf-formatting branch 2 times, most recently from 2e43da3 to df33aee Compare August 20, 2025 13:14
@chr-hertel
Copy link
Member

I'm afraid it needs patches in the tests as well

@OskarStark
Copy link
Contributor Author

It does, will have a look soon

@OskarStark OskarStark changed the title Fix exceptions to use sprintf for string formatting Fix exceptions to use sprintf for string formatting Aug 21, 2025
Replace string concatenation and interpolation with sprintf in all exception messages for consistency and better formatting.
@OskarStark OskarStark force-pushed the fix-exception-sprintf-formatting branch from df33aee to af0051f Compare August 21, 2025 19:24
@OskarStark OskarStark merged commit 1a910fd into symfony:main Aug 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants