Skip to content

[Platform][Gemini] Add TokenOutputProcessor #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

[Platform][Gemini] Add TokenOutputProcessor #347

merged 1 commit into from
Sep 2, 2025

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Aug 24, 2025 •
edited by OskarStark
Loading

Q A
Bug fix? no
New feature? yes
Docs? no
Issues Fix #...
License MIT

According to https://ai.google.dev/api/generate-content?hl=en#UsageMetadata

This will need the AsTokenUsageProcessor from PR of @junaidbinfarooq

@carsonbot carsonbot changed the title Add TokenOutputProcessor for Gemini Add TokenOutputProcessor for Gemini Aug 24, 2025
OskarStark
OskarStark reviewed Aug 24, 2025
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an example in examples/ folder? Thanks

OskarStark
OskarStark reviewed Aug 24, 2025
View reviewed changes
@chr-hertel
Copy link
Member

Should wait for #329

@VincentLanglet
Copy link
Contributor Author

Should wait for #329

Yeah, I will rebase after ;)

@OskarStark OskarStark added the Platform Issues & PRs about the AI Platform component label Aug 25, 2025
@carsonbot carsonbot changed the title Add TokenOutputProcessor for Gemini [Platform] Add TokenOutputProcessor for Gemini Aug 25, 2025
@VincentLanglet VincentLanglet mentioned this pull request Aug 25, 2025
Merged
@VincentLanglet
Copy link
Contributor Author

Should wait for #329

Since #329 seems currently stuck/unfinished, I wonder if this PR couldn't be review/merged first and then #329 will rebased it.

This way I'll be able to use my Processor @chr-hertel :)

@OskarStark OskarStark changed the title [Platform] Add TokenOutputProcessor for Gemini [Platform][Gemini] Add TokenOutputProcessor for Gemini Aug 28, 2025
@OskarStark OskarStark changed the title [Platform][Gemini] Add TokenOutputProcessor for Gemini [Platform][Gemini] Add TokenOutputProcessor Aug 28, 2025
@chr-hertel
Copy link
Member

Ready for rebase 👍

@OskarStark OskarStark changed the title [Platform][Gemini] Add TokenOutputProcessor [Platform][Gemini] Add TokenOutputProcessor Sep 2, 2025
OskarStark
OskarStark reviewed Sep 2, 2025
View reviewed changes
OskarStark
OskarStark reviewed Sep 2, 2025
View reviewed changes
OskarStark
OskarStark approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my comments

chr-hertel
chr-hertel requested changes Sep 2, 2025
View reviewed changes
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs the bundle registration now :)

@OskarStark
Copy link
Contributor

Also needs the bundle registration now :)

Indeed, I missed that

@VincentLanglet
Copy link
Contributor Author

Ready @chr-hertel

@OskarStark OskarStark force-pushed the geminiOutputProcessor branch from 2b5c5a1 to 59cc045 Compare September 2, 2025 09:56
@OskarStark
Copy link
Contributor

Thank you @VincentLanglet.

@OskarStark OskarStark merged commit a071848 into symfony:main Sep 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

@chr-hertel chr-hertel Awaiting requested review from chr-hertel chr-hertel is a code owner

+1 more reviewer

@junaidbinfarooq junaidbinfarooq junaidbinfarooq left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Feature New feature Platform Issues & PRs about the AI Platform component Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VincentLanglet @chr-hertel @OskarStark @junaidbinfarooq @carsonbot