chore: update bundle for latest lib changes #74
Merged
+29
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Jul 7, 2025
OskarStark
approved these changes
Jul 7, 2025
| $container->setDefinition('symfony_ai.indexer.'.$name.'.vectorizer', $vectorizerDefinition); | ||
|
|
||
| $definition = new Definition(Indexer::class, [ | ||
| '$vectorizer' => new Reference('symfony_ai.indexer.'.$name.'.vectorizer'), |
There was a problem hiding this comment.
If I am not mistaken, but I am currently on a phone 📱, we don't use named argument in Symfony, but index based assignments.
cc @Nyholm
Ofc in an extra PR
chr-hertel
added a commit
that referenced
this pull request
Jul 7, 2025
This PR was merged into the main branch. Discussion ---------- chore: update demo to latest changes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | | License | MIT Cherry piclking php-llm/llm-chain-symfony-demo#29 Waits for * #74 * #73 Commits ------- 1f74c6c chore: update to llm-chain 0.24 (#29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking php-llm/llm-chain-bundle#101
Needs #73