Skip to content

Update to Symfony 5.2 #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

Update to Symfony 5.2 #1163

merged 1 commit into from
Dec 15, 2020

Conversation

javiereguiluz
Copy link
Member

No description provided.

stof
stof reviewed Oct 8, 2020
View reviewed changes
@stof
Copy link
Member

stof commented Oct 8, 2020

have you checked where the new deprecation comes from ?

@javiereguiluz
Copy link
Member Author

@stof yes ... it's from Symfony's Twig Loader pass ... but I was going to fix it and couldn't, because apparently it's been fixed since the beta release:

image

@stof
Copy link
Member

stof commented Oct 8, 2020

this might indicate missing tests in Symfony, as the testsuite should forbid deprecations...

@javiereguiluz javiereguiluz changed the title Update to Symfony 5.2 beta1 Update to Symfony 5.2 beta2 Oct 22, 2020
@javiereguiluz javiereguiluz mentioned this pull request Oct 22, 2020
Closed
@javiereguiluz
Copy link
Member Author

@stof @nicolas-grekas after upgrading to Symfony 5.2 beta3 I can still see that deprecation. Is this something to be fixed upstream in Symfony? Thanks! Details:

image

@javiereguiluz javiereguiluz changed the title Update to Symfony 5.2 beta2 Update to Symfony 5.2 beta3 Oct 29, 2020
@javiereguiluz javiereguiluz changed the title Update to Symfony 5.2 beta3 Update to Symfony 5.2 RC1 Nov 10, 2020
@javiereguiluz
Copy link
Member Author

I've just updated to 5.2 RC1. I don't see any issues or deprecations ... and the application feels super lightweight and responsive.

@nicolas-grekas nicolas-grekas changed the base branch from master to main November 19, 2020 12:36
@javiereguiluz
Copy link
Member Author

I've updated to 5.2 RC2. These are the reported deprecations:

Remaining indirect deprecation notices (7)

  6x: The "Doctrine\Common\Inflector\Inflector::classify" method is deprecated and will be dropped in doctrine/inflector 2.0. Please update to the new Inflector API.
    2x in AddUserCommandTest::testCreateUserNonInteractive from App\Tests\Command
    2x in AddUserCommandTest::testCreateUserInteractive from App\Tests\Command
    1x in BlogControllerTest::testAdminNewPost from App\Tests\Controller\Admin
    1x in UserControllerTest::testEditUser from App\Tests\Controller

  1x: Since symfony/dependency-injection 5.2: The "Symfony\Component\DependencyInjection\Alias::setPrivate()" method is deprecated, use "setPublic()" instead.
    1x in AddUserCommandTest::testCreateUserNonInteractive from App\Tests\Command

@javiereguiluz javiereguiluz changed the title Update to Symfony 5.2 RC1 Update to Symfony 5.2 Dec 15, 2020
@javiereguiluz javiereguiluz merged commit c6009c3 into symfony:main Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javiereguiluz @stof